Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouquet of GUI fixes and improvements. #151

Merged
merged 10 commits into from
May 25, 2024

Conversation

cristian64
Copy link
Collaborator

A collection of small fixes and improvements:

  • Enable per-pixel scrolling in table-like widgets.
  • Define initial column width based on font metrics.
  • Configure certain columns to fit to content (addresses and watch types).
  • Show application icon in Memory Viewer dialog.
  • Use system's fixed-width font for address and value columns.
  • Center check boxes in Lock column.
  • Keep watcher widget enabled at all times, even when not hooked to Dolphin 1.
    • Value editing is now disallowed when not hooked to Dolphin.
  • Drop label for the scan base group box.
  • Select entire row when auto-selecting newly inserted rows.

Footnotes

  1. Even though the widget and the buttons are enabled, there are certain operations such as adding watch entries or editing addresses that will not work: DME currently attempts to verify memory addresses before accepting the address, which will fail if not hooked. This will be addressed in a separate work item.

Qt's default behavior (i.e. scroll per cell) is not user friendly when
wide cells (e.g. **Scanned** and **Current** columns in the scanner
pane) are present.
…ain columns to fit to content.

Columns whose content width is known in advance (addresses and watch
types) are now configured to fit to content.
@cristian64 cristian64 changed the title Bouquet of gui fixes Bouquet of GUI fixes and improvements. May 24, 2024
The preexisting item delegate is used for painting and event handling.
Previously, the widget would be set to a disabled state when DME was not
hooked to Dolphin.
The label is only occupying vertical space; the set of options is
self-explanatory.
Row auto-selection was introduced in 43ec849, but it was overlooked
that only one cell in each row was being selected.
@dreamsyntax dreamsyntax merged commit 0060c79 into aldelaro5:master May 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants