Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge many commits and several changes to design #17

Closed

Conversation

Luis-Henriquez-Perez
Copy link
Contributor

STILL A WORK IN PROGRESS

I changed the internal design in several ways. Most notably, I am changing what the ob-extended-tangle does. I don't think we should/need to create another header argument. Instead, I'm merely hijacking the tangle argument and allowing us to reroute its inteded location to somewhere else. I still need to work out what happens in the case of tangle yes.

@Luis-Henriquez-Perez Luis-Henriquez-Perez force-pushed the develop branch 2 times, most recently from 7081656 to 2004a35 Compare May 1, 2021 18:28
@Luis-Henriquez-Perez
Copy link
Contributor Author

First, I got tangld-build to work! 😄 finally! 🎉

I changed the ob-expanded-tangle.el (actually I may end up removing this file).

Instead of adding a new :relative-dir header argument, I rerouted the existing :tangle header arguments to the correct path. I like this approach better because it works with an existing argument instead of adding a new one.

My approach assumes that the user will write these :tangle arguments relative to the tangld system dir. So with direct building the path ~/.config/emacs/init.el would be rerouted to ~/.tangld/src/build/.config/emacs/init.el (assuming of course ~/ is the system dir).

important caveat

As I was testing this I noticed that org-babel-tangle relies on some external state. If you use file header args like the ones below and you modify them you must restart org mode.

#+TITLE: config.org
#+AUTHOR: Luis-Henriquez-Perez
#+PROPERTY: header-args :tangle ~/.config/emacs/init.el
#+TAGS: emacs config

@Luis-Henriquez-Perez Luis-Henriquez-Perez force-pushed the develop branch 2 times, most recently from 0924410 to 9b87d4f Compare May 2, 2021 00:42
@aldrichtr aldrichtr added emacs-package Emacs lisp and package enhancement New feature or request tangle The org-babel-tangle process labels May 24, 2021
@aldrichtr aldrichtr removed the emacs-package Emacs lisp and package label May 24, 2021
@aldrichtr aldrichtr added this to the version 1.0 milestone May 24, 2021
@aldrichtr aldrichtr linked an issue May 24, 2021 that may be closed by this pull request
4 tasks
@aldrichtr
Copy link
Owner

I've just started to go through the changes.... there are quite a lot! I'll get back to you very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tangle The org-babel-tangle process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants