Always enable bookmarks #4011
Open
Always enable bookmarks #4011
+14
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been an "experimental feature" since 2021. And it seems simple enough? So just always enable it.
|
Thanks for opening this PR :). The bookmarks feature was never enabled by default and it isn't a widely-used feature in Aleph. Making it a default feature would increase the code complexity for maintainers of self-deployed instances. It would also widen the set of on-by-default features we have to support. I would like to keep this PR open for now, because good work went into it. We may merge it down the line. For now, we're not seeing a need to make it a core feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been an "experimental feature" since 2021. And it seems simple enough? So just always enable it.