-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a concept of ambigous KOD table #13
Open
erdgeist
wants to merge
16
commits into
master
Choose a base branch
from
erdgeist-strucrack-ambigous-kods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cracking heuristics can not completely deduct a KOD table, allow for unresolved entries with the value of -1 To fix up some of these entries, the user can provide a new fix for the table via the -f option. To further guide the user, print out preliminarily decoded struc records and some stats about duplicated and missing KOD mappings.
… and decoded candidates in color
…is the way forward
…only its components
Not sure how to add that #22 to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cracking heuristics can not completely deduct a KOD table, allow for unresolved entries with the value of -1
To fix up some of these entries, the user can provide a new fix for the table via the -f option.
To further guide the user, print out preliminarily decoded struc records and some stats about duplicated and missing KOD mappings.