un-skip test for tasks which shouldn't execute

alephdata · Jun 12, 2024 · 7192299 · 7192299
1 parent 87ffe7e
commit 7192299
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/tests/test_taskqueue.py b/tests/test_taskqueue.py
@@ -107,7 +107,6 @@ def test_task_queue(self):
         end_time = unpack_datetime(status["end_time"])
         assert started < end_time < last_updated
 
-    @skip("Unfinished")
     @patch("servicelayer.taskqueue.Dataset.should_execute")
     def test_task_that_shouldnt_execute(self, mock_should_execute):
         test_queue_name = "sls-queue-ingest"
@@ -147,6 +146,18 @@ def did_nack():
 
         worker = CountingWorker(queues=[test_queue_name], conn=conn, num_threads=1)
         assert not dataset.should_execute(task_id=task_id)
-        worker.process(blocking=False)
+        with patch.object(
+            worker,
+            attribute="dispatch_task",
+            return_value=None,
+        ) as dispatch_fn:
+            with patch.object(
+                pika.channel.Channel,
+                attribute="basic_nack",
+                return_value=None,
+            ) as nack_fn:
+                worker.process(blocking=False)
+                nack_fn.assert_any_call(delivery_tag=1, multiple=False, requeue=True)
+                dispatch_fn.assert_not_called()
 
         channel.close()