Banxa UI tweaks / first steps into app redesign #776
Conversation
🦋 Changeset detectedLatest commit: c17105b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mvaivre
changed the title
mvaivre
force-pushed
the
banxa-UI-tweaks
branch
from
5739ef9 to
b8f348a
Compare
There was a problem hiding this comment.
First pass ✅
I see that this PR goes into banxa, which is good because I read that Android is not ready yet so it makes sense to merge this in a feature branch (like we do with Tanstack in DW).
However, the previous PR went into next. Do you think that blocks us from releasing MW (the auth fixes)?
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
hm, i don't like this downgrades, I don't see anything changed in our package.json...
Issue: pointerEvents non not working on Android cf: Shopify/react-native-skia#2551
mvaivre
force-pushed
the
banxa-UI-tweaks
branch
from
7f57665 to
1e26b11
Compare
If it's okay for you, I'll improve this in the follow up PR #794 |
| {Platform.OS === 'android' ? ( | ||
| <TransparentCardBackground style={StyleSheet.absoluteFill} /> | ||
| ) : ( | ||
| <BlurView | ||
| style={StyleSheet.absoluteFill} | ||
| intensity={80} | ||
| tint={theme.name === 'dark' ? 'systemThickMaterialDark' : 'systemThickMaterialLight'} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
BlurView does not work well on Android?
This is a first step towards a full redesign.
This allows us to test & tweak the new look and feel before going further. Tested mostly on iOS.
Android needs some fixes which will come in a subsequent PR (cf. Shopify/react-native-skia#2551)