Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pops up twice when connecting with desktop wallet #243

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Aug 21, 2023

The wcDisconnect depends on signerProvider, and the desktopWalletConnect depends on wcDisconnect. After the wallet is connected, calling useConnect returns a new desktopWalletConnect instance, which leads to the pops up twice. In fact, desktopWalletConnect doesn't need to depend on wcDisconnect.

The reason this issue didn't exist in previous versions is that we only call the connect once in the ConnectWithDesktopWallet component(the dependencies list is empty):

@Lbqds Lbqds requested a review from polarker August 21, 2023 03:18
@polarker polarker merged commit a947d7a into master Aug 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants