Fix pops up twice when connecting with desktop wallet #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wcDisconnect
depends onsignerProvider
, and thedesktopWalletConnect
depends onwcDisconnect
. After the wallet is connected, callinguseConnect
returns a newdesktopWalletConnect
instance, which leads to the pops up twice. In fact,desktopWalletConnect
doesn't need to depend onwcDisconnect
.The reason this issue didn't exist in previous versions is that we only call the
connect
once in theConnectWithDesktopWallet
component(the dependencies list is empty):alephium-web3/packages/web3-react/src/components/ConnectModal/ConnectWithDesktopWallet.tsx
Line 33 in 8cf20fe