Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard Interface For NFT Collection With Royalty #248

Merged
merged 4 commits into from
Aug 26, 2023

Conversation

h0ngcha0
Copy link
Member

No description provided.

@h0ngcha0 h0ngcha0 requested review from Lbqds and polarker and removed request for Lbqds August 25, 2023 07:29
@h0ngcha0 h0ngcha0 requested a review from Lbqds August 25, 2023 15:15
Copy link
Member

@Lbqds Lbqds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@polarker
Copy link
Member

polarker commented Aug 25, 2023

@h0ngcha0 As Splinter pointed out on discord, most of the royalties design as NFT based, not collection based. That can be more flexible because one might mint multiple rounds for a same collection with different royalties.

We will need to update our NFT prototype to be NFT based loyalties.

@h0ngcha0
Copy link
Member Author

h0ngcha0 commented Aug 25, 2023

@h0ngcha0 As Splinter pointed out on discord, most of the royalties design as NFT based, not collection based. That can be more flexible because one might mint multiple rounds for a same collection with different royalties.

We will need to update our NFT prototype to be NFT based loyalties.

@polarker

Question: Which NFT marketplace has NFT based royalty design? On Opensea Royalty fee is set at the collection level. (https://docs.opensea.io/docs/10-setting-fees-on-secondary-sales)

On EVM there is only the collection contract so I guess it has to be set at the collection level. However the royalty amount can be calculated per token id, that is why we have the following method in the interface

pub fn royaltyAmount(tokenId: ByteVec, salePrice: U256) -> (U256)

@polarker
Copy link
Member

@h0ngcha0 As Splinter pointed out on discord, most of the royalties design as NFT based, not collection based. That can be more flexible because one might mint multiple rounds for a same collection with different royalties.
We will need to update our NFT prototype to be NFT based loyalties.

@polarker

Question: Which NFT marketplace has NFT based royalty design? On Opensea Royalty fee is set at the collection level. (https://docs.opensea.io/docs/10-setting-fees-on-secondary-sales)

On EVM there is only the collection contract so I guess it has to be set at the collection level. However the royalty amount can be calculated per token id, that is why we have the following method in the interface

pub fn royaltyAmount(tokenId: ByteVec, salePrice: U256) -> (U256)

You are right. I missed that tokenId is enough for NFT-based royalties. All good then!

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h0ngcha0 h0ngcha0 merged commit 72b9309 into master Aug 26, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants