-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Standard Interface For NFT Collection With Royalty #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@h0ngcha0 As Splinter pointed out on discord, most of the royalties design as NFT based, not collection based. That can be more flexible because one might mint multiple rounds for a same collection with different royalties. We will need to update our NFT prototype to be NFT based loyalties. |
Question: Which NFT marketplace has NFT based royalty design? On Opensea Royalty fee is set at the collection level. (https://docs.opensea.io/docs/10-setting-fees-on-secondary-sales) On EVM there is only the collection contract so I guess it has to be set at the collection level. However the royalty amount can be calculated per token id, that is why we have the following method in the interface
|
You are right. I missed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.