Fix audit with pnpm audit --prod --fix
#416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nop33
commented
Sep 4, 2024
.github/workflows/audit.yml
Outdated
| @@ -22,4 +22,4 @@ jobs: | |||
| - uses: pnpm/action-setup@v4 | |||
| with: | |||
| version: 9.4 | |||
| - run: pnpm audit | |||
| - run: pnpm audit --prod | |||
There was a problem hiding this comment.
@h0ngcha0 don't you think it makes sense to only audit packages that are used in production
There was a problem hiding this comment.
Sorry for being late, would it be an issue if we audit all packages? devDependencies might affect our dev environment so if we can maybe we should audit as well, WDYT?
|
@nop33 It seems only webpack needs to be patched for dev deps. Can you give it a try? |
This reverts commit 319d7e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.