Walletconnect: auto connect #794
Conversation
|
|
||
| const tryRestoreLastSession = useCallback( | ||
| async (client: SignClient) => { | ||
| if (!client.session.length) return resetSession() |
There was a problem hiding this comment.
Note to myself: When checking for active sessions, we should probably first cross-reference them with the active pairings. See: https://github.com/alephium/mobile-wallet/blob/master/src/utils/walletConnect.ts#L50-L58
|
Thanks for this PR @Lbqds! As per request from the community I've implemented in my PR #802 the feature of handling multiple WalletConnect sessions. This includes initializing the app state with the current active WalletConnect sessions, derived from the client. I believe this covers the use case of this PR as well, so I believe it's not needed anymore. Let me know if you think differently! |
|
Great work👍, feel free to close it if it's not needed! |
|
I think I'll keep it open until the new desktop wallet version is released, then we can test together to verify that the requirements of this PR are met 😉 |
The branch for the @alephium/web3 is here: alephium/alephium-web3#270
When testing with
npm run start:electron, please be mindful NOT to use CTRL + C to shutdown the client. Electron won't persist localStorage in this case. And I triedprocess.on('exit', () => app.quit()), but it still does not work.