familiarized myself with the repo #560
Conversation
…-A since it failed in CI for some reason...
|
try upgrade |
|
oh, can you pls replace all |
framework/react/markup.ts
Outdated
There was a problem hiding this comment.
what this file for? i did see you import it
There was a problem hiding this comment.
I started adding some stuff for a possible future feature, realized it might be too large to just add in and that's an artifact from that. I was going to use it to scrub markup data from loader data and that sort of thing. I can remove it for the time being, I should probably open an issue discussing changes I'd want to work on/implement for the project.
There was a problem hiding this comment.
First big issue I have to report/figure out has to do with data coming from the data export on routes. I get very strange results. I'll write something up to display that issue and give possible solutions
I have a formatter that made a lot of tweaks, All tests should run fine and behave. Main thing added was to dev.ts and server/dev.ts Just adding args. I also started looking at other parts of the repo, and added a markup.ts file into the react folder. I can remove it as it currently does nothing, but was planning to use it for a future commit.
Also used the data object export in the todos app example instead since it seems like more commonly users would want an async function that syntax supports async.
Let me know what changes if any are needed to add this in.