Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Build Checks #12

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Jul 18, 2024

This pull request introduces build checks that occur on a pull request the allows for greater trust in pull requests not breaking the package.

I've added the pull_request event into the existing action workflow file as opposed to making another action as it was already responsible for a build job however it only performed it on release which could lead to broken builds if a failure isn't picked up in review.

To solve the issue of other release jobs running on every pull request, I've added conditions to all jobs checking the intended event that triggered the workflow run, runs only what is defined by the condition.

I'll look into some caching additions and other QoL changes in the future

@kashw2 kashw2 changed the title CI Improvements Pull Request Build Checks Jul 18, 2024
@alepiumetti
Copy link
Owner

Thank for your contribution! 😊

You’re right that it will save us trouble in the future.

I find this addition to the workflow really useful.

@alepiumetti alepiumetti merged commit b608094 into alepiumetti:main Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants