Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create del_ins_markdown_3_0_1.py #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bvermeulen
Copy link

Please can you pull this version of del_ins as it is compatible with Markdown 3.0.1

Thanks, Bruno Vermeulen
[email protected]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bvermeulen bvermeulen closed this Dec 10, 2018
@bvermeulen bvermeulen reopened this Dec 10, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bvermeulen
Copy link
Author

Please can you pull this branch as this is del_ins markdown 3.0.1 compatible

Copy link

@muggenhor muggenhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a complicated variant of PR #1.

pip install git+git://github.com/aleray/mdx_del_ins.git


copy mdx_del_ins_markdown_3_0_1.py as a module

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a regression in usability to me. Dependency management with pip is a highly desirable feature.

>>> src = """This is ++added content++ and this is ~~deleted content~~"""
>>> html = markdown.markdown(src, ['del_ins'])
>>> html = markdown.markdown(src, extensions=[DelInsExtension()])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to the loss of installability via pip this makes configurations more complicated.

@@ -0,0 +1,43 @@
# -*- coding: utf-8 -*-

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you're copy-pasting this entire file instead of modifying it to be compatible with markdown 3.0. Why is that?


def makeExtension(*args, **kwargs): # noqa: N802
'''Inform Markdown of the existence of the extension.'''
return Del_InsExtension(*args, **kwargs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo and I don't expect to be able to execute. Did you test it?

Suggested change
return Del_InsExtension(*args, **kwargs)
return DelInsExtension(*args, **kwargs)

@honzajavorek
Copy link

Hi 👋 I've forked the original package as markdown-del-ins, updated it, and published as markdown-del-ins. It's tested and I plan to maintain it. Feel free to use it instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants