-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create del_ins_markdown_3_0_1.py #2
base: master
Are you sure you want to change the base?
Conversation
Please can you pull this branch as this is del_ins markdown 3.0.1 compatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a complicated variant of PR #1.
pip install git+git://github.com/aleray/mdx_del_ins.git | ||
|
||
|
||
copy mdx_del_ins_markdown_3_0_1.py as a module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a regression in usability to me. Dependency management with pip is a highly desirable feature.
>>> src = """This is ++added content++ and this is ~~deleted content~~""" | ||
>>> html = markdown.markdown(src, ['del_ins']) | ||
>>> html = markdown.markdown(src, extensions=[DelInsExtension()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to the loss of installability via pip this makes configurations more complicated.
@@ -0,0 +1,43 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems you're copy-pasting this entire file instead of modifying it to be compatible with markdown 3.0. Why is that?
|
||
def makeExtension(*args, **kwargs): # noqa: N802 | ||
'''Inform Markdown of the existence of the extension.''' | ||
return Del_InsExtension(*args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a typo and I don't expect to be able to execute. Did you test it?
return Del_InsExtension(*args, **kwargs) | |
return DelInsExtension(*args, **kwargs) |
Hi 👋 I've forked the original package as markdown-del-ins, updated it, and published as markdown-del-ins. It's tested and I plan to maintain it. Feel free to use it instead! |
Please can you pull this version of del_ins as it is compatible with Markdown 3.0.1
Thanks, Bruno Vermeulen
[email protected]