Fix missing post (#1131)

* Fix missing post

* Update node version in GH Actions

.github/workflows/workflow.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: '13.14'
+          node-version: '12.19'
       - run: npm ci
       - run: npm run type-check
       - run: npm run lint

__tests__/pages/index.test.tsx

@@ -46,7 +46,6 @@ const posts = [
       frontmatter: {
         title: 'Third post',
         date: 'January 3, 1980',
-        spoiler: '3...',
         keywords: ['keyword three'],
       },
       fields: {
@@ -78,7 +77,8 @@ describe('Homepage', () => {
       screen.getByText('A blog by Alessia Bellisario')
     ).toBeInTheDocument();
 
-    // displays 3 posts
+    // displays 3 posts, and expects all to be there...
+    // ...even the node without a spoiler
     expect(screen.getAllByText(/post/i)).toHaveLength(3);
     posts.forEach(({ node: { frontmatter, fields } }) => {
       expect(
@@ -87,9 +87,17 @@ describe('Homepage', () => {
       expect(
         screen.getByText(frontmatter.title || fields.slug)
       ).toHaveAttribute('href', fields.slug);
-      expect(screen.getByText(frontmatter.spoiler)).toBeInTheDocument();
     });
 
+    // expects the spoilers that do exist (they are optional)
+    // to be in the document
+    expect(
+      screen.getByText(posts[0].node.frontmatter.spoiler || '')
+    ).toBeInTheDocument();
+    expect(
+      screen.getByText(posts[1].node.frontmatter.spoiler || '')
+    ).toBeInTheDocument();
+
     // can open and close details
     userEvent.click(screen.getByText(/filter by tag/i));
     expect(

src/pages/index.tsx

@@ -97,10 +97,7 @@ const BlogIndex = ({
           })
           .map(({ node: { id, fields, frontmatter } }) => (
             <div key={id} style={{ margin: '1.5rem 0' }}>
-              {fields?.slug &&
-              frontmatter?.title &&
-              frontmatter?.spoiler &&
-              frontmatter?.date ? (
+              {fields?.slug && frontmatter?.title ? (
                 <>
                   <h3>
                     <BlogLink to={fields.slug}>{frontmatter.title}</BlogLink>

tsconfig.json

@@ -10,5 +10,5 @@
     "noFallthroughCasesInSwitch": true,
     "allowSyntheticDefaultImports": true
   },
-  "include": ["src/**/*"]
+  "include": ["src/**/*", "__tests__/**/*"]
 }