-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nachrichten - Rework #218
base: main
Are you sure you want to change the base?
Nachrichten - Rework #218
Conversation
+ May not follow project "guidelines"
flutter_chat_ui sieht sehr solide aus. Das Example ist wirklich einfach und soweit ich das sehe, kann man über textMessageBuilder auch eigene sachen sehr gut einbauen (hier vor allem markup) |
…tions # Conflicts: # app/pubspec.yaml
Ich denke es wäre hier super hilfreich, wenn anstelle von dynamic eigene klassen für alles erstellt werden. Das hat mir bei den substituzions sehr geholfen und ist sehr viel cleaner. |
Ja das ist eine gute Idee |
+ There is no style yet + Clearing create dialog doesn't work yet
…tions # Conflicts: # app/pubspec.yaml
+ Now part of Message + Color correctly styled to current theme brightness and color
Das ist schon sehr groß geworden. 1.000 Zeilen an neuen Code. |
…ff that wasn't added in the previous commit
Ich glaube das ist jetzt endlich ready. Ich hoffe ich habe nichts vergessen. |
+ Removed during a debug removal commit + Now also set position to the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also specify the return type of client.substitutions.getOverview
with a special data class. I where not able to mark that with the review tool in InteliJ since it was not changed
Looks good overall, I will implement the UI things I talked about, but seems solid (or as solid as it can be for our situation).
I wanted to do the overview thing later in a separate PR where I also rework it but I'll look into it. The scroll to bottom FAB doesn't show itself directly, only if I scrolled down; I'll look into that. Und soll ich jetzt Englisch oder Deutsch hier auf Github benutzen, weil irgendwie wird das immer herumgeswitcht. |
+ Revert remove text button to delete_all + Removed back button in send.dart + searchTeacher() function now returns only a receiverTeacher class and added the fromJson() constructor to it. + ConversationParser class stores result of the canChooseType() function + Put type chooser dialog into a Scaffold
So now the UI needs to be adjusted bc the dialogues were just put in a Scaffold without really changing them and exceptions. |
+ Subject text field expands + Add receiver field received icons, etc. + Removed buttons, added FABs
+ Remove borders, add elevation => fits better + Receivers have now icons whether they're a group, teacher or etc.
+ Replace beautiful ExpansionTiles with boring RadioListTiles + Put dialog functions into Stateful Widgets
+ Fix mistake in overview ErrorView (!content -> !error) + Adjust translation for no connection + Replace fetcher parameter with function parameter in ErrorView + Add AppBar to ErrorView + Add report buttons to ErrorView + If NoConnectionException occurred, display "No internet connection" instead of a critical error screen
I think it's ready. After that the overview needs to be cleaned and maybe then I can do experimental ideas like a dashboard? |
Die alte Nachrichten ( - Beta-Version) PR will ich nicht für immer zum vergammeln hier lassen, somit wird es jetzt gemacht.
Main TODOs im Code:
Andere issues:
MessageState.first
gesendetdynamic
beim FetcherPotenzielle Performance issues:
LinkedList anstatt eines Arrays?Wenn man eine neue Nachricht sendet muss man immer den voherigen Item überprüfen, also ich weiß ob es dann so viel bringt.Bringt nix mehrZur Impeller-Engine wechseln, mache wahrscheinlich ein eigenes Issue dazu.