Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes support for rxjs 7 #42

Closed

Conversation

sithwarrior
Copy link

@sithwarrior sithwarrior commented Nov 27, 2021

This updates the peerdependency of rxjs to include version 7.

rxjs 7 has no breaking changes that relates to backoff-rxjs, but provides benifts, such as a smaller bundle size.

btw fixes #36

@sithwarrior
Copy link
Author

Hi @alex-okrushko Sorry to bother you, but could you review this single line change?

It provides support for installing backoff-rxjs in a project with rxjs 7.

It simply updates the peerdependency to include ^7.0.0

@clark-stevenson
Copy link

Hey @alex-okrushko 👋

I am just here to bump this PR. I am updating to Angular 13 and it has a dependency of RXJS 7.4.0

Using ng update rxjs causes the update to fail with:

Package "backoff-rxjs" has an incompatible peer dependency to "rxjs" (requires "^6.5.5", would install "7.4.0")

@sithwarrior has awesomely got us covered with this PR 👍

Thanks for the awesome lib!

@alex-okrushko
Copy link
Owner

Hey @clark-stevenson and @sithwarrior. I'll update & release it soon. There is one morr change that I want to land before that.
Thanks for the PR.

@sithwarrior
Copy link
Author

Hey @alex-okrushko have you had some time to review this? Let me know if you need a hand with anything

@sithwarrior
Copy link
Author

Hey @alex-okrushko Sorry to bump this, but would be nice with a release. Please let me know if you need a hand with anything.

@alex-okrushko
Copy link
Owner

updated to support rxjs v7 @sithwarrior @clark-stevenson

@clark-stevenson
Copy link

Thank you @alex-okrushko ! 🤗 I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade package to support RxJS v8.0
3 participants