This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Add a thing to make using BufferCollator as some sort of queue easy and ... #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,9 +187,16 @@ API Reference | |||
|
|
|||
| Adds the contents of a view to the collator. | |||
|
|
|||
| .. method:: collapse() | |||
| .. method:: collapse(max_bytes=-1) | |||
There was a problem hiding this comment.
Below you called it max_length.
| @@ -453,16 +452,29 @@ def append(self, view): | |||
| self._views.append(view) | |||
| self._total_length += len(view) | |||
|
|
|||
| def collapse(self): | |||
| def collapse(self, max_bytes=-1): | |||
There was a problem hiding this comment.
why not None instead of a sentinel value?
(ok, so technically None is a sentinel value, but at least it is of a different type)
|
Also, have you considered making collapse a non-destructive operation? it could just create a buffer and leave the old stuff there. You'd need to allow passing a start index in addition to a max_bytes, though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...fast