Improve scores feed performance #1

alexTakeoff · Jan 30, 2023 · 354c950 · 354c950
1 parent b1b3a07
commit 354c950
Show file tree

Hide file tree

Showing 8 changed files with 178 additions and 3 deletions.
diff --git a/.idea/.gitignore b/.idea/.gitignore
diff --git a/.idea/golfr_backend.iml b/.idea/golfr_backend.iml
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/.idea/modules.xml b/.idea/modules.xml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -229,6 +229,7 @@ GEM
 
 PLATFORMS
   x86_64-darwin-20
+  x86_64-darwin-22
 
 DEPENDENCIES
   bootsnap (>= 1.4.4)

diff --git a/app/controllers/api/scores_controller.rb b/app/controllers/api/scores_controller.rb
@@ -6,7 +6,16 @@ class ScoresController < ApplicationController
 
     def user_feed
       scores = Score.all.order(played_at: :desc, id: :desc)
-      serialized_scores = scores.map(&:serialize)
+      users = User.all
+
+      users_map = {}
+      users.each do |user|
+        users_map[user.id] = user.name
+      end
+
+      serialized_scores = scores.map do |score|
+        score.serialize(users_map[score.user_id])
+      end
 
       response = {
         scores: serialized_scores,

diff --git a/app/models/score.rb b/app/models/score.rb
@@ -7,11 +7,11 @@ class Score < ApplicationRecord
   validates :total_score, inclusion: { in: 54..120 }
   validate :future_score
 
-  def serialize
+  def serialize(username)
     {
       id: id,
       user_id: user_id,
-      user_name: user.name,
+      user_name: username,
       total_score: total_score,
       played_at: played_at,
     }