Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add automatic license checking with pylic #3

Merged
merged 16 commits into from
Dec 11, 2023
Merged

Conversation

AJDERS
Copy link
Contributor

@AJDERS AJDERS commented Nov 29, 2023

Adds basic checking of licenses for the dependencies in a the repository using Pylic. Right now i simply added the entire list of OSI accepted OS licenses.

@AJDERS AJDERS self-assigned this Nov 29, 2023
@AJDERS AJDERS requested a review from saattrupdan November 29, 2023 13:33
Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. But otherwise I think it would be great if a "Check licenses of dependencies [Y/n]?" option in the cookiecutter, and remove all these things if this is "n".

{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
@AJDERS AJDERS requested a review from saattrupdan November 30, 2023 10:17
@AJDERS AJDERS requested a review from saattrupdan December 11, 2023 09:26
Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AJDERS AJDERS merged commit 2a347eb into main Dec 11, 2023
2 checks passed
@AJDERS AJDERS deleted the feat/license-checking branch December 11, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants