forward plugin stderr to host without hclog #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stream agent logs over grpc with the Opni CLI, I have a custom logger in rancher/opni#1774 that logs plugin grpc messages to the plugin
stderr, which go-plugin forwards to the agent host process inlogStderr. The logs from the agent host process are then streamed to the gateway.By default, go-plugin takes everything written to
stderrand attempts to log it as a structured hclog log. If hclog parsing fails, it casts the output as a string before forwarding to the host (l.Debug(string(line))). My grpc[]bytemessage is casted to a string which causes undefined behaviour. Instead, I'd like to directly forward everything from the plugin stderr without the hclog parsing.