Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output in single comment #3

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Output in single comment #3

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
438dcea
Output in single comment
alexcekay Oct 30, 2024
e01fdfc
fix multiline output var
alexcekay Oct 30, 2024
9c9910b
Join with newline
alexcekay Oct 30, 2024
61038c9
Trying to fix multiline string
alexcekay Oct 30, 2024
ef9f385
Prettier comment
alexcekay Oct 30, 2024
a3883fa
Added missing comma
alexcekay Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion .github/workflows/flash_analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ jobs:
strategy:
matrix:
target: [px4_fmu-v5x, px4_fmu-v6x]
outputs:
px4_fmu-v5x: ${{ steps.gen-output.outputs.output_px4_fmu-v5x }}
px4_fmu-v6x: ${{ steps.gen-output.outputs.output_px4_fmu-v6x }}
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -61,14 +64,47 @@ jobs:
bloaty-args: -d sections,compileunits -n 0 ./with-change.elf -- ./before-change.elf
output-to-summary: true

- name: Generate output
id: gen-output
run: |
EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
echo "output_${{ matrix.target }}<<$EOF" >> $GITHUB_OUTPUT
echo "${{ steps.bloaty-step.outputs.bloaty-output-encoded }}" >> $GITHUB_OUTPUT
echo "$EOF" >> $GITHUB_OUTPUT

post_pr_comment:
name: Post PR comment
runs-on: ubuntu-latest
needs: [analyze_flash]
steps:
- name: If it's a PR add a comment with the bloaty output
if: ${{ github.event.pull_request }}
uses: actions/github-script@v6
with:
script: |
const comment = [
'## FLASH Analysis',
'### px4_fmu-v5x',
'<details>',
'<summary>Bloaty output</summary>',
'',
'```',
`${{ needs.analyze_flash.outputs.px4_fmu-v5x }}`,
'```',
'</details>',
'',
'### px4_fmu-v6x',
'<details>',
'<summary>Bloaty output</summary>',
'',
'```',
`${{ needs.analyze_flash.outputs.px4_fmu-v6x }}`,
'```',
'</details>'
]
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: '## Bloaty output (${{ matrix.target }})\n```\n${{ steps.bloaty-step.outputs.bloaty-output-encoded }}```\n'
body: comment.join('\n')
})
Loading