Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.2.0 #217

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Bump to 3.2.0 #217

merged 2 commits into from
Dec 8, 2023

Conversation

amousset
Copy link
Collaborator

Still working on reducing the size of the crate, a lof of big stuff was added.

@alexcrichton
Copy link
Owner

If it's too difficult to trim out the extra bits I can also email crates.io folks to try to get the size limit for this crate increased to 20M for example.

@heiher
Copy link
Contributor

heiher commented Dec 4, 2023

Can we exclude some unused documents to reduce the package size? Assume that the crate size limit cannot be increased anytime soon.

diff --git a/Cargo.toml b/Cargo.toml
index c32d75d..45b85de 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -21,6 +21,9 @@ exclude = [
   'openssl/tlsfuzzer/*',
   'openssl/python-ecdsa/*',
   'openssl/oqs-provider/*',
+# The current upload size limit for *.crate files is 10MB. Therefore, exclude
+# some unused documentation to meet this constraint.
+  'openssl/doc/man{3,5,7}',
 ]
 
 [features]
target/package/openssl-src-300.2.0+3.2.0.crate  9570580 bytes

It doesn't look like this breaks the build, I'll create a PR as soon as possible if we can do it, as this upgrade is important for LoongArch (There is a change included in 3.2.0 that fixes the build issue).

Updated:

PR: #219

@alexcrichton
Copy link
Owner

Want to try rebasing over #219 and see if this passes CI now?

@alexcrichton
Copy link
Owner

The sizing bits look good (thanks @heiher!) but it looks like there may be new runtime dependencies on Windows? Probably "just" a missing -l argument though (unsure which one myself without googling further)

@alexcrichton
Copy link
Owner

Oh I think that the line you'll need to modify is around here

@heiher
Copy link
Contributor

heiher commented Dec 8, 2023

Oh I think that the line you'll need to modify is around here

Fixed: #221

@amousset
Copy link
Collaborator Author

amousset commented Dec 8, 2023

Thanks @heiher, I picked your commit (sorry for the latency, I'm not very available these days).

@alexcrichton alexcrichton merged commit 90dae38 into alexcrichton:main Dec 8, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants