Add issuemail CAA record support #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!I’m in the French alps just now but will look at this and respond early next week.Thanks again!Sent from my iPhoneOn 10 Apr 2024, at 22:32, Ryan Doherty ***@***.***> wrote:When a hostname has an issuemail record, DNSRuby throws an error:
dig +short CAA esmt.org
0 issuemail "pki.dfn.de"
0 issuewild "sectigo.com"
0 issue "sectigo.com"
0 issue "pki.dfn.de"
0 issuemail "sectigo.com"
0 issue "letsencrypt.org"
resolver.query('esmt.org', 'CAA')
NoMethodError: undefined method `[]' for nil:NilClass
from /usr/local/lib/ruby/gems/3.0.0/gems/dnsruby-1.61.5/lib/dnsruby/resource/CAA.rb:47:in `from_string'
The issuemail record is a relatively new RFC: https://datatracker.ietf.org/doc/rfc9495/
I think I did this right, lmk what can be improved/changed!
You can view, comment on, or merge this pull request online at:
#193
Commit Summary
0feacc5 Add issuemail CAA record support
File Changes (2 files)
M
lib/dnsruby/resource/CAA.rb
(2)
M
test/tc_caa.rb
(1)
Patch Links:
https://github.com/alexdalitz/dnsruby/pull/193.patch
https://github.com/alexdalitz/dnsruby/pull/193.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Looks good to me - thanks! |
alexdalitz
approved these changes
Apr 15, 2024
|
Thank you @alexdalitz ! Yeah it would be nice to get this in a release soon, our application that uses this Gem is unable to do some DNS checks that it needs to do and is impacting our customers. Thank you! |
|
OK - v1.72.1 is out now with this fix included |
|
Thank you @alexdalitz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a hostname has an
issuemailrecord, DNSRuby throws an error:The issuemail record is a relatively new RFC: https://datatracker.ietf.org/doc/rfc9495/
I think I did this right, lmk what can be improved/changed!