Hide master label section if empty #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexed1 This also fixes a bug introduced to the flowCombobox by PR#1581 |
|
@alexed1 I was able to create a new v3.3.8 with these changes |
jdayment
approved these changes
Jan 22, 2025
|
@jdayment Are you able to merge any PR or just those you have been asked to review? |
|
I think it's just ones I've been asked to review
…On Wed, Jan 22, 2025, 5:23 PM Eric Smith ***@***.***> wrote:
@jdayment <https://github.com/jdayment> Are you able to merge any PR or
just those you have been asked to review?
—
Reply to this email directly, view it on GitHub
<#1623 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS7YVURGTQMHWPC5CTJQT2MAZB3AVCNFSM6AAAAABVAERJF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBYGU3DGMJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexed1 #1549 introduced extra spacing in the header of fsc_pickObjectAndField3. This update hides that new header if no value is provided for masterLabel.
I will build a new FlowScreenComponentsBase pack.