Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScriptCore support #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add JavaScriptCore support #198

wants to merge 1 commit into from

Conversation

pasamio
Copy link

@pasamio pasamio commented May 28, 2020

JavaScriptCore is Apple's Javascript implementation and uses the now standard globalThis to expose the global variable. This adds sprintf to the global space for JavaScriptCore.

@alexei
Copy link
Owner

alexei commented Mar 4, 2021

I think the dist files should be regenerated

@pasamio pasamio force-pushed the master branch 2 times, most recently from f0845b8 to 07a5763 Compare March 7, 2021 18:23
JavaScriptCore is Apple's Javascript implementation and uses the now standard `globalThis` to expose the global variable. This adds sprintf to the global space for JavaScriptCore.
@pasamio
Copy link
Author

pasamio commented Mar 7, 2021

Updated, did a change so that lint doesn't get confused by globalThis as undefined as well. Let me know if there is anything else missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants