New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modified queue to use VecDeque instead of Vec #98

Merged

alexfertel merged 1 commit into alexfertel:main from Daniel729:queue-vecdeque

Oct 9, 2024

Contributor

Daniel729 commented Oct 9, 2024

Also removed pointless return value of Queue::enqueue (if it fails it panics)

The original implementation's dequeue runs with O(n) efficiency, as pointed out by Vec::remove's documentation:

Note: Because this shifts over the remaining elements, it has a worst-case performance of O(n).


          feat: modified queue to use VecDeque instead of Vec

ace12ed

Also removed pointless return value of Queue::enqueue (if it fails it panics)

alexfertel approved these changes

View reviewed changes

Owner

alexfertel commented Oct 9, 2024

Thank you!

alexfertel merged commit 06c906d into alexfertel:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet