-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update everything and add tests for almost everything #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is failing because of an incomplete util module
This is failing because of a missing WIP _shims.js file
Note this requires the PR-23 in buffer-browserify fix
Note punycode related test has been removed
Amazing! I was going to have to do this as part of michaelficarra/commonjs-everywhere#72. You're a hero. |
@michaelficarra thanks, I really appreciate those words. |
Relative paths increases the complexity of any require implementation and this is also how node.js works
Fantastic work! |
alexgorbatchev
added a commit
that referenced
this pull request
Aug 24, 2013
Major update for 2.0. Thanks @AndreasMadsen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed stream2 in my browser and I was quite surprised to see how outdated this module was. I ended up updating everything since I figured I would get other incompatibility if I didn't. So here it is, the Pull Request of doom. It took me more that 2 full days of boring work so I really hope this doesn't gets pulled aside.
This also adds about 2100 tests that I took from nodecore and I have rewritten the README.md so I contains information about how to use the module (nothing changed here) and how to contribute properly.
I really hope the no tests days are over and that the maintainers of this module will be strict in the future.
Also note that I have changed the version to
2.0.0
since this will likely introduce some breaking changes. I have tried to keep a list about whats changed, but as this was mostly no-brainer copypast this most likely incomplete.Browser support: