init calculator unit test #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDD / extreame programing try
alexkutsan
reviewed
Jul 20, 2020
src/Calculator/calculator.cpp
Outdated
| continue; | ||
| } | ||
|
|
||
| if (isOperator(token.at(0))) { |
There was a problem hiding this comment.
suggest to thing about continue refactoring of the for loop
| m_tmp_operands.push(atof(token.c_str())); | ||
| } | ||
|
|
||
| Calculator::result Calculator::handleOperatorToken(const std::string &token) |
There was a problem hiding this comment.
do assertion in places where you need
| return 0.0; | ||
| if (isOperator(token)) { | ||
| if (!handleOperatorToken(token)) { | ||
| return {}; |
There was a problem hiding this comment.
In case if there is wrong input, user will see 0 as calculation result?
| ASSERT_EQ(calculator.calculate("0 3 2 + /"), 0); | ||
| } | ||
|
|
||
| TEST_F(CalculatorTest, SimbolNotSuported) { |
There was a problem hiding this comment.
Not enough tests for negative test cases
| continue; | ||
| } | ||
|
|
||
| m_error = "input simbol: " + token + " not supported!"; |
There was a problem hiding this comment.
suggest to extract token validation to separate loop and use calculation loop without error handling for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDD / extreame programing try