Upgrade to use awssdk v2 #47
Open
+151
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addtionally upgraded sl4fj, java, and simplified test execution against S3. The ability to test directly against S3 is vitally important.
skiyooka
commented
Sep 19, 2024
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>sso</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
I provide my AWS credentials on the command line using aws sso login
|
@skiyooka I no longer have time to maintain this library and I barely remember anything about Java or AWS. At this stage I think it would be best to archive this repository, link to your fork, and you can create a new package on maven or whatever repository people use nowadays. WDYT? |
|
@alexmojaki I'm flattered for the offer. I unfortunately don't have the bandwidth to become the maintainer either. |
|
I wanted to take the time to create this PR as I recognize good work when I see it... and this saved me a bunch of time to solve a difficult problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addtionally upgraded sl4fj, java, and simplified test execution against S3.
Thank you @alexmojaki for your library. It provided a great solution and starting point to solve the creation of a large .zip from S3 files and stream the resulting .zip (of unknown size) back.
The ability to test directly against S3 is vitally important to ensure that the changes are working correctly and to assure that this library is safe to use. This testing uncovered an interesting detail that the eTag in awssdk v2 are surrounded by double quotes.
I took a look at jclouds, s3proxy, etc. and while they look interesting I did not have enough time to figure them out and I was also concerned by the lack of activity in jclouds. Hence I figured that for future users, the easiest approach would be to remove them altogether and allow those interested in running the tests to do so directly against S3.
Also thank you @alexwhiteoval for your PR. I reviewed it to ensure I didn't miss anything and you had a more elegant way to incorporate the customise* handlers.