Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: add l2cap connection-oriented channel support. #13

Merged
merged 5 commits into from
Mar 27, 2024
Merged

android: add l2cap connection-oriented channel support. #13

merged 5 commits into from
Mar 27, 2024

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Mar 20, 2024 •
edited
Loading

  • android: generate bindings from api level 33.
  • android: add InputStream, OutpuTStream to bindings.
  • android: add l2cap connection-oriented channel support.

Coming after this PR: L2CAP on iOS, basic Android GATT.

part of #3 #9

alexmoon
alexmoon reviewed Mar 26, 2024
View reviewed changes
Copy link
Owner

@alexmoon alexmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you fix the unused parameter clippy lints?

src/android/l2cap_channel.rs Show resolved Hide resolved
@alexmoon alexmoon merged commit 039f625 into alexmoon:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmoon alexmoon alexmoon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @alexmoon