Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛏️ Generate an image from a Prompt using SVG.io #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juli4nb4dillo
Copy link
Collaborator

I'm using this AI image generator: https://api.svg.io/v1/docs
To make an image from a prompt you need an API Key.

Screenshot 2024-11-03 at 2 57 04 PM

@juli4nb4dillo
Copy link
Collaborator Author

sorry for the formatting, my vscode is set up with one of the default formatters for javascript.

@alexrudd2
Copy link
Owner

sorry for the formatting, my vscode is set up with one of the default formatters for javascript.

(╯°□°)╯︵ ┻━┻

Well, fix it then :)

Copy link
Owner

@alexrudd2 alexrudd2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an API key and therefore can't test anything. :(

So my review is mostly just superficial comments to fit in with the rest of the codebase.

I think the "AI" tab should go into the "More" tab. And perhaps the prompt could go in the svg drag-n-drop target?

src/ui.tsx Outdated Show resolved Hide resolved
src/ui.tsx Outdated Show resolved Hide resolved
src/ui.tsx Outdated Show resolved Hide resolved
@juli4nb4dillo
Copy link
Collaborator Author

I undid most of the formatting, it needs work, but I don't want to obscure the stuff I did because of it.
I'll make a new PR with re-formatting, it's awful and inconsistent all around.

@juli4nb4dillo
Copy link
Collaborator Author

juli4nb4dillo commented Nov 8, 2024

I don't have an API key and therefore can't test anything. :(

I'll send you my key

I think the "AI" tab should go into the "More" tab. And perhaps the prompt could go in the svg drag-n-drop target?

I like my own tab, but I like the prompt idea, If I figure out how to pop-up modals and do a 2-step workflow I'll do it.

@alexrudd2
Copy link
Owner

I undid most of the formatting, it needs work, but I don't want to obscure the stuff I did because of it. I'll make a new PR with re-formatting, it's awful and inconsistent all around.

#96

Also, for a while my priority had been to keep things as close to https://github.com/nornagon/saxi as possible, so they could be upstreamed: https://github.com/users/alexrudd2/projects/1. However, that looks less and less likely (nornagon has a young child)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants