Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ESM and ECMA2022 (second attempt) #181

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Migrate to ESM and ECMA2022 (second attempt) #181

wants to merge 4 commits into from
+60 −49

Conversation

alexrudd2
Copy link
Owner

@alexrudd2 alexrudd2 commented Mar 3, 2025 •
edited
Loading

Closes #179

Better attempt at #178 which had to be reverted.

npm run dev, npm run start, and npm run dev all work for me, but I didn't try with IS_WEB

@alexrudd2 alexrudd2 marked this pull request as draft March 3, 2025 02:40
@alexrudd2 alexrudd2 marked this pull request as ready for review March 3, 2025 03:56
@alexrudd2 alexrudd2 requested a review from juli4nb4dillo March 3, 2025 03:56
@alexrudd2 alexrudd2 mentioned this pull request Mar 3, 2025
Draft
1 task
@juli4nb4dillo
Copy link
Collaborator

I'll try better on the afternoon, but on a clean install, on clean build and npm start I get:

Screenshot 2025-03-03 at 8 18 08 AM

So it doesn't find static assets.

npm run dev works fine though.

Web mode only also seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juli4nb4dillo juli4nb4dillo Awaiting requested review from juli4nb4dillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module './dist/server/server'
2 participants
@alexrudd2 @juli4nb4dillo