Add basic server smoke test #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedahan
approved these changes
Oct 4, 2023
| @@ -11,8 +11,9 @@ import { EBB } from "./ebb"; | |||
| import { Device, PenMotion, Motion, Plan } from "./planning"; | |||
| import { formatDuration } from "./util"; | |||
| import { autoDetect } from '@serialport/bindings-cpp'; | |||
| import * as self from './server' // for mocking | |||
There was a problem hiding this comment.
Is there a link to documentation for this? Its a new pattern to me, but otherwise this looks good!
There was a problem hiding this comment.
Its just a little weird to me, like wouldn't you get infinite recursive imports?
There was a problem hiding this comment.
Exporting the function was the only way I found that allowed jest to mock it. It doesn't appear to recurse (presumably after the first export jest "grabs" it and stops the recursion?)
I have no idea if it's a good pattern or not; it was trial-and-error.
alexrudd2
added a commit
that referenced
this pull request
Oct 26, 2023
alexrudd2
added a commit
that referenced
this pull request
Oct 26, 2023
alexrudd2
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See upstream version nornagon#187
This is a basic smoke test to make sure the Express server starts
(sometimes dependency updates break it).