Issue #26 #27
Issue #26 #27
Conversation
Remember that this variant uses File.read/gsub/File.write to modify manifest*.json files
|
Not so sure about this - I definitely don't think removing the digest files should be the default behaviour. I haven't looked into the manifest very much so I don't know if it makes sense to have both digest and non digest in the manifest, but I'm a bit hesitant to merge without knowing more about how it works and making removing the digested files an option rather than the default. |
|
It makes no sense if you're only using the logical paths in your app. The manifest is simply a hash with the logical path as key, wich would be the same for non-digest and digest files. But if you're using hardcoded paths you'd be better off not altering the manifest. In this case the logical path would be translated to the digest file. |
| @@ -25,6 +25,11 @@ class Manifest | |||
| def compile_with_non_digest *args | |||
| compile_without_non_digest *args | |||
|
|
|||
| assets_path = ::Rails.root.join('public', 'assets', 'manifest*.json') | |||
There was a problem hiding this comment.
Can this line be replaced with @filename. The initializer for the Manifest class allows for passing a completely different manifest file name.
https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/manifest.rb#L18-L54
|
@armanm initializing a Manifest with the filename was the first thing i tried. Unfortunately i had do discover that the |
|
@alexspeller and i'm sorry for the wrong information, but the keys in the manifest are the filenames. An entry would like that: But as the asset-path-helpers search for the logical path, i guess there will always be returned the first match. So you'd either need additional helper-methods for non-digest asset-paths or address them without helpers, but that would kill the logical-path <=> filename concept. |
rewriting manifest, deletes digest-files and entries, adds non-digest entries
cherry-picked 1588a04
concerning issue #26