-
Notifications
You must be signed in to change notification settings - Fork 157
Added the ability to select items using arrow keys #44
base: master
Are you sure you want to change the base?
Conversation
@lisandromc your tests have failed, did you see why? |
In some contexts, $listeners.keydown will be undefined and that breaks the component. |
Hi! I have just installed vue-boostrap-typeahead package and I notice that keyboard navigation is still not working. Do you have any news on this? Thanks |
This is the exact reason I wanted to revive (but ended up having to fork: https://github.com/mattzollinhofer/vue-typeahead-bootstrap) this repository. I really wanted a more accessible tool to use and I saw this (and other) PRs that had already been submitted to solve the problem! To that end, I merged in functionality that I think meets this need here: mattzollinhofer@6646027. This implementation is mildly different but I believe the outcome is essentially the same. Thanks again and chime in here or on the fork if you have any other thoughts! 😄 You can find the functionality on npm here: https://www.npmjs.com/package/vue-typeahead-bootstrap. |
Cool, thank you!
…On Tue, Mar 3, 2020 at 1:56 PM Admire ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AOPEM4FW7FUNRCVWDZM3IUTRFTV7PA5CNFSM4G7SHF6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXW7U5A#pullrequestreview-367917684>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOPEM4CZFWYVGSUYJVSV7YTRFTV7PANCNFSM4G7SHF6A>
.
|
Fixes #37 .
You may want to look at VueBootstrapTypeaheadList.vue's setActiveItem method, since it's perhaps not the cleanest solution.