Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Added the ability to select items using arrow keys #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lisandromc
Copy link

@lisandromc lisandromc commented Mar 19, 2019

Fixes #37 .

You may want to look at VueBootstrapTypeaheadList.vue's setActiveItem method, since it's perhaps not the cleanest solution.

@fabiolima fabiolima mentioned this pull request Mar 26, 2019
@fabiolima
Copy link

@lisandromc your tests have failed, did you see why?

@lisandromc
Copy link
Author

@lisandromc your tests have failed, did you see why?

In some contexts, $listeners.keydown will be undefined and that breaks the component.
I have a fix for this, but I belatedly noticed that my PR should be done in the Development branch (duh!).
I will replace this with a proper PR as soon as I have some spare time.

@nicpillinger nicpillinger mentioned this pull request Jul 3, 2019
mp205 pushed a commit to mp205/vue-bootstrap-typeahead that referenced this pull request Jan 13, 2020
@pvisarion
Copy link

Hi! I have just installed vue-boostrap-typeahead package and I notice that keyboard navigation is still not working. Do you have any news on this? Thanks

@mattzollinhofer
Copy link

This is the exact reason I wanted to revive (but ended up having to fork: https://github.com/mattzollinhofer/vue-typeahead-bootstrap) this repository. I really wanted a more accessible tool to use and I saw this (and other) PRs that had already been submitted to solve the problem!

To that end, I merged in functionality that I think meets this need here: mattzollinhofer@6646027. This implementation is mildly different but I believe the outcome is essentially the same.

Thanks again and chime in here or on the fork if you have any other thoughts! 😄

You can find the functionality on npm here: https://www.npmjs.com/package/vue-typeahead-bootstrap.

@pvisarion
Copy link

pvisarion commented Mar 3, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow keys
5 participants