Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Add support for minMatchingChars=0 #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jhalag
Copy link

@jhalag jhalag commented Apr 15, 2019

Add support for minMatchingChars=0

Replacement PR for #40 with discrete source branch.

Allow displaying the list on initial select if minMatchingChars==0
@jhalag jhalag changed the title Feature/maxchars 0 Add support for minMatchingChars=0 Apr 15, 2019
@jhalag jhalag changed the base branch from Development to master April 15, 2019 21:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 62

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 70.297%

Totals Coverage Status
Change from base Build 38: 0.9%
Covered Lines: 48
Relevant Lines: 69

💛 - Coveralls

jhalag added a commit to jhalag/vue-bootstrap-typeahead that referenced this pull request Apr 16, 2019
@mattzollinhofer
Copy link

This is a great PR, thanks for the work!

I merged in functionality that I think meets this need here: mattzollinhofer/vue-typeahead-bootstrap@09a6cf7. This implementation refers to it as showOnFocus rather than re-using minMatchingChars but I believe the outcome is essentially the same unless I'm not understanding.

You can use the functionality under the forked project: https://www.npmjs.com/package/vue-typeahead-bootstrap or https://github.com/mattzollinhofer/vue-typeahead-bootstrap.

Hope this helps anyone who needs this functionality going forward!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants