Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Update scoped slot suggestion template #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhalag
Copy link

@jhalag jhalag commented May 15, 2019

Update template example to use Vue 2.60+ syntax. See https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots
(cherry picked from commit a9cfc7e)

Update template example to use Vue 2.60+ syntax. See https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots
(cherry picked from commit a9cfc7e)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 64

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.388%

Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 47
Relevant Lines: 68

💛 - Coveralls

@mattzollinhofer
Copy link

I'm just plowing through the obvious problems right now to get those fixed/merged. This is a good idea, but I'll need some time to determine the impact of this change. I'm still somewhat new to Vue and don't fully understand the impacts of changes across versions.

This looks like a positive change on the surface so I'll definitely take a look at this PR again, hopefully soon.

Please do chime in if you can educate me about and dangers of conflict (or that I shouldn't be worrying about it 😄 ) either here or on the new repo: https://github.com/mattzollinhofer/vue-typeahead-bootstrap/

@mattzollinhofer
Copy link

This is fine, but not something I want to take on for the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants