Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Added 'No results found' on emtpy matchedItems #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wpgeek922
Copy link

Added a message for better user experience on empty results.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 69

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.388%

Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 47
Relevant Lines: 68

💛 - Coveralls

Copy link

@mattzollinhofer mattzollinhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid PR and worked as expected when I pulled it down and ran it locally.

Is this something you're still looking for?

@hamiltonmneto
Copy link

Is there any particular reason for this PR not been merged? I'm using this component and getting complaning about not having a message on empty results

@mattzollinhofer
Copy link

Is there any particular reason for this PR not been merged? I'm using this component and getting complaning about not having a message on empty results

Yeah I just took a stab at this and ran into a few decisions to make that I'm not entirely sure about and ran out of time to work through. If you'd like to add some thoughts or take a stab at it you can take a look at this PR: mattzollinhofer/vue-typeahead-bootstrap#44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants