Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview settings intercept #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

airandfingers
Copy link

Messily fixes #57 for Salesforce authentication by adding a "webviewSettingsIntercept" callback option to ITnsOAuthOptionsSalesforce

@airandfingers
Copy link
Author

I know these changes have a few problems:

  1. They only apply to the Salesforce auth method, because that's all I'm using.

  2. webviewSettingsIntercept is treated as a required argument.

  3. The callback is called 50+ times per login, when using our Salesforce auth servers.

For 1 and 2, I can add this option to other auth methods and make it optional, if that's the route @alexziskind1 wants to take.

As for 3, I'm not sure where else to call the callback from; I tried calling it from TnsOAuthPageProvider:loginPageFunc, but webview.android and webview.ios were undefined.

Also, it may be better to expose the webview as a property instead of having API consumers pass a callback. However, I'm not sure how this would work - perhaps adding getWebview functions to multiple layers, instead of passing webviewSettingsIntercept during initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Webview component
1 participant