Nativescript 7.x support #125
Conversation
- Compiled with typescript@~3.9.2 - Fixed issue reported by tsc on querystring - tns-core-modules & platform-declarations updated - added @types/node - *.iml (idea) project files ignored
In my case, the signature hash, and thus the redirect Uri, contains an `=`. It is already encoded into `%3D` when I copy it from the Azure Portal, but it has to be passed as `%253D` when passing it into the HTTP request method, because somewhere along the line it is decoded and won't come across correctly. The error I got was that the redirect_uri didn't match the one from the Azure Portal. After this change, it worked as expected.
- Compiled with typescript@~3.9.2 - Fixed issue reported by tsc on querystring - tns-core-modules & platform-declarations updated - added @types/node - *.iml (idea) project files ignored
…ativescript-oauth2 into feature/nativescript-7-support
https://www.npmjs.com/package/tns-core-modules "The tns-core-modules package exists only for compatibility with older versions of NativeScript. It's recommended to use @nativescript/core now." Using @nativescript/core in plugin and all sample projects
tns-core-modules to @nativescript/core migration needs some updates in the import syntax
|
@funder7 thanks for the PR. is this backwards compatible with ns6? |
|
Hi @alexziskind1 actually this version is compatible with ns6, I made some confusion with versions :-) I think that it's safer to merge this into a new branch, instead of master directly... Now I'm using it on Android, but I've got no chance to test in on iOS! Some ns modules have been updated in the meanwhile, I'm going to test & commit the update. We could name this version |
funder7
changed the title
- update: @nativescript/core rc.21→rc.24
- using @nativescript/types references
- added -rc.x prefix to module version
- clean script removes js & map
- {N} platform version updated to 6.0.0
src/package.json
Outdated
| @@ -1,13 +1,13 @@ | |||
| { | |||
| "name": "nativescript-oauth2", | |||
| "version": "2.5.0", | |||
| "version": "2.5.0-rc.0", | |||
There was a problem hiding this comment.
@nativescript/core and types are not released as stable yet, I would follow that naming to let the user know about upcoming updates, once stable packages are released
|
Thanks for the PR. I'm going to close this out as I've done the update separately on a live stream so more folks could benefit (i hope). But I appreciate your contribution |
What is the current behavior?
The plugin is not usable inside a NativeScript project using Angular version >= 9
What is the new behavior?
Dependencies have been updated in order to make the project compatible with [email protected]. Apparently this ts version is required to allow the import inside a Nativescript-Angular project which is using the new Ivy compiler since angular@9
Important notes
qsObj["code"]-->qsObj.code.toString()has been tested on Android and works, by the way some tests would be a nice to have.Fixes #124 .
Fixes #114 .