Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static handleIncomingUrl #139

Closed
wants to merge 1 commit into from
Closed

static handleIncomingUrl #139

wants to merge 1 commit into from

Conversation

OniQ
Copy link

@OniQ OniQ commented Nov 9, 2020

PR Checklist

What is the current behavior?

Uncaught TypeError: this.handleIncomingUrl is not a function

What is the new behavior?

Fixes #138

@alexziskind1
Copy link
Owner

I'm closing this as the original issue #138 is Android related and this PR targets iOS only. Furthermore, after testing, there is no such issue that I could reproduce on iOS.

@JohanBeumer
Copy link

@alexziskind1 Please consider reopening this PR. I'm getting the error only on iOS, but only in my own project in which I also use firebase. Putting the solution of this PR in place solves it.

However in the community chat of 23rd september starting at minute 13 @NathanWalker and @cjohn001 discussed #135 which is exactly what I am experiencing. So maybe there is a better solution?

Unfortunately I'm not familiar enough with delegates to be able to put the solution @NathanWalker suggests in place. Any help with that is appreciated!

Lastly I searched the code of the repo and handleIncomingUrl only is in the sources :
demo-angular/node_modules/nativescript-oauth2/delegate/delegate.ios.js
demo-angular/node_modules/nativescript-oauth2/delegate/index.ios.js
src/delegate/index.ios.js
src/delegate/index.ios.ts
so it must be an iOS thing, right?

@hammelev
Copy link

@alexziskind1 please open the PR again. The current version breaks my application when used together with the firebase plugin on iOS when attempting to login. Adding this PR fixes the error and allows my application to login.

@nc-kfl
Copy link

nc-kfl commented Dec 16, 2020

Nice work with this package for NativeScript @alexziskind1 and @OniQ. What are the changes that this can be reopned? On my project we have problems with the firebase plugin too and the fixed in this pull-request has shown to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth 2 - Google - After Sigin not redirected back to app
5 participants