Custom driver provider tests #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added steps for entering random numbers (alfa-laboratory#60)
fork update
Update fork
Add opposite checking steps part2 (alfa-laboratory#68)
Update BlackListManager.java
Обновление
added description for 'blacklist' (alfa-laboratory#77)
setted latest version of browser by default (alfa-laboratory#76)
Добавлен headless режим для chrome и firefox 🦄 (alfa-laboratory#91)
| CustomDriverProvider customDriverProvider = new CustomDriverProvider(); | ||
| WebDriver currentDriver; | ||
| currentDriver = customDriverProvider.createDriver(new DesiredCapabilities()); | ||
| assertThat(currentDriver.getClass().getName(), is("org.openqa.selenium.chrome.ChromeDriver")); | ||
| assertThat(currentDriver.manage().window().getSize().getWidth(), is(666)); | ||
| assertThat(currentDriver.manage().window().getSize().getHeight(), is(666)); | ||
| currentDriver.quit(); | ||
| } | ||
|
|
||
| @Ignore | ||
| @Test | ||
| public void createFirefoxDriverTest() { |
There was a problem hiding this comment.
тесты с установкой размера окна для разного типа драйверов излишни. механизм установки одинаковый. имеет смысл проверить, что создается именно нужного типа драйвер. но для этого нужно дополнительно добавить поддержку запуска этого драйвера в travis или через контейнеры попробовать реализовать
There was a problem hiding this comment.
установку размеров удалил, travis ковыряю
| } | ||
|
|
||
| @Test | ||
| public void createNonexistentDriverTest() { |
There was a problem hiding this comment.
тут лучше default термин использовать
| } | ||
|
|
||
| @Test | ||
| public void createEmptyDriverTest() { |
There was a problem hiding this comment.
если createNonexistentDriverTest пройдет, то этот тоже
Fix/remove debug (alfa-laboratory#116)
…mDriverProvider-tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.