Add DataTable for some steps with fields #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkekkonen
reviewed
Apr 9, 2020
| */ | ||
| @Тогда("^(?:поля|элементы) содержат значения из таблицы") | ||
| @Then("^(?:fields|elements) contain values from the DataTable") | ||
| public void testActualValuesContainsSubstrings(DataTable arg) { |
There was a problem hiding this comment.
'test' — это префикс юнит-тестовых методов. Зачем он здесь?
alkekkonen
reviewed
Apr 9, 2020
| for (int i = 0; i < table.size(); i++) { | ||
| String elementName = table.get(i).get("elementName"); | ||
| String value = table.get(i).get("value"); | ||
| testActualValueContainsSubstring(elementName, value); |
alkekkonen
reviewed
Apr 9, 2020
| @Then("^(?:fields|elements) contain values from the DataTable") | ||
| public void testActualValuesContainsSubstrings(DataTable arg) { | ||
| List<Map<String, String>> table = arg.asMaps(String.class, String.class); | ||
| for (int i = 0; i < table.size(); i++) { |
There was a problem hiding this comment.
Nitpick: неплохое место, чтобы использовать стрим.
alkekkonen
reviewed
Apr 9, 2020
| List<Map<String, String>> table = arg.asMaps(String.class, String.class); | ||
| for (int i = 0; i < table.size(); i++) { | ||
| String elementName = table.get(i).get("inputName"); | ||
| String value = table.get(i).get("value"); |
There was a problem hiding this comment.
Так ли нужно дублировать это три строчки? Вероятно, есть смысл положить их в отдельный метод.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил несколько шагов с групповым вводом и проверкой значений в полях с использованием DataTable.