Skip to content

MAGE-1236: Add Backend Rendering Manager #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

MAGE-1236: Add Backend Rendering Manager #1844

merged 2 commits into from
Oct 9, 2025

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Oct 7, 2025

This PR adds:

  • Refactored AddAlgoliaAssetsObserver
  • Introduced RenderingManagerTest Service
  • Added unit tests

@damcou damcou requested a review from cammonro October 7, 2025 13:59
@damcou damcou self-assigned this Oct 8, 2025
cammonro
cammonro reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments in Jira.

cammonro
cammonro approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like that we've fully covered the display mode logic in the tests.

@damcou damcou merged commit 04562fb into release/3.18.0-dev Oct 9, 2025
4 checks passed
@damcou damcou deleted the feat/MAGE-1326-prevent-backend-rendering branch October 9, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammonro cammonro cammonro approved these changes

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damcou @cammonro