Skip to content

fix: bugs #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bugs #80

wants to merge 1 commit into from

Conversation

bejarano-tech
Copy link

…client

Fix the Bug Submission Pull Request

What was the bug?

It had two bugs:

  • In the appClient instantiation the creatorAddress was receiving the deployer object instead the deployer address.
  • In the appClient instantiation the algod (AlgoClient) param was receiving the indexer client instead of the algod client.

How did you fix the bug?

  • In order to fix one bug i have passed to the creatorAddress the deployer address by calling deployer.addr.
  • In order to fix the other bug I have replaced the indexer with algod client in order to pass the param properly.

Console Screenshot:

Screenshot 2024-04-07 at 08 36 53

@iskysun96 iskysun96 added the Approved ✅ Successfully completed the challenge! label Apr 12, 2024
@iskysun96
Copy link
Contributor

🎉 Congrats on solving the 3rd Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/qtrccanc047y79h9ymzjqs07javhjfd254makz8fbegt66jwn8w4k73zfaf6fsjgk1wkh9xq5dsfddx7vyfq1fcvrbdjxkmjp5cqy0g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Approved ✅ Successfully completed the challenge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bejarano-tech @iskysun96