-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cyrillic render to HTML #60
Conversation
The thing with "P100" is actually a bug. Last commit to that line broke it. The rest of this I feel should be implemented in a way that allows to easily add more code pages. Probably by putting all the code pages into a dict and selecting one from the CLI. |
Hi Ali, I've made an update to "cyrillic" branch. Now "--cyrillic" switch is replaced with "--localcodepage" where codepage should be passed as string. Character set g0 was rearranged as a dict with "default" charset used as before and "cyr" charset used for "localcodepage". Polish, German etc. codepages could be added to have support for printing them to HTML. Regards, |
Thanks! It might be after Christmas before I can properly look at this and merge it. |
Thank you, I'm looking forward to it :) |
Hi Ali, Let me kindly remind about my pull request 🙂 Thanks, |
Why is the default |
Merging this as-is for now. I squashed the letter fix. |
Hi Ali,
There is a bit rough implementation for cyrillic support in html render. Oprion "cyrillic" was added, character set is Cyrillic G0 Set - Option 2 (Russian/Bulgarian).
Regards,
Alexander