This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
add support for mixpanel and fixed test #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| target[fn] = -> | ||
| target.push([fn].concat(slice.call(arguments))) | ||
|
|
||
| functions = 'disable track track_pageview track_links track_forms register register_once alias unregister identify name_tag set_config people.set people.set_once people.increment people.append people.track_charge people.clear_charges people.delete_user'.split(' ') |
There was a problem hiding this comment.
You should define these methods as an Array just like:
https://github.com/teambition/gta/blob/master/src/index.coffee#L179
It would be clearer in format and better in performance.
|
Could you please run grunt task before your code commited |
Brooooooklyn
force-pushed
the
recover-mixpanel
branch
from
5778ebb to
8f478b7
Compare
|
landed as 2cd2b9b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.