add comments and update docker

alibaba · Feb 27, 2024 · d504cf3 · d504cf3
1 parent bb5e69e
commit d504cf3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/docs/source/train.md b/docs/source/train.md
@@ -194,9 +194,9 @@ pai -name easy_rec_ext -project algo_public
 ### 依赖
 
 - 混合并行使用Horovod做底层的通信, 因此需要安装Horovod, 可以直接使用下面的镜像
-- mybigpai-registry.cn-beijing.cr.aliyuncs.com/easyrec/easyrec:sok-tf212-gpus-v4
+- mybigpai-registry.cn-beijing.cr.aliyuncs.com/easyrec/easyrec:sok-tf212-gpus-v5
   ```
-    sudo docker run --gpus=all --privileged -v /home/easyrec/:/home/easyrec/ -ti mybigpai-registry.cn-beijing.cr.aliyuncs.com/easyrec/easyrec:sok-tf212-gpus-v4 bash
+    sudo docker run --gpus=all --privileged -v /home/easyrec/:/home/easyrec/ -ti mybigpai-registry.cn-beijing.cr.aliyuncs.com/easyrec/easyrec:sok-tf212-gpus-v5 bash
   ```
 
 ### 配置

diff --git a/easy_rec/python/compat/sok_optimizer.py b/easy_rec/python/compat/sok_optimizer.py
@@ -228,8 +228,6 @@ def apply_sparse_gradients(self, grads_and_vars, global_step=None, name=None):
         for slot_name in self._initial_vals:
           if key not in self._optimizer._slots[slot_name]:
             tmp_slot_var_name = v._dummy_handle.op.name + '/' + self._optimizer._name
-            # import pdb
-            # pdb.set_trace()
             if v.backend_type == 'hbm':
               with ops.colocate_with(v):
                 slot = DynamicVariable(

diff --git a/easy_rec/python/protos/feature_config.proto b/easy_rec/python/protos/feature_config.proto
@@ -145,6 +145,8 @@ message FeatureConfig {
 
 message FeatureConfigV2 {
     repeated FeatureConfig features = 1 ;
+    // force place embedding lookup ops on cpu to improve
+    // training and inference efficiency.
     optional bool embedding_on_cpu = 2 [default=false];
 }