-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interactive): Implement admin http service for hqps engine #3322
Conversation
fb5eabf
to
42f26c1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
=======================================
Coverage 41.04% 41.04%
=======================================
Files 109 109
Lines 11298 11298
=======================================
Hits 4637 4637
Misses 6661 6661 Continue to review full report in Codecov by Sentry.
|
b8caf56
to
8a68e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
introduce admin service move file into folder move file into folder make sure http service is ready add graph manager and todo: loading graph and delete graph todo: add query service stash fix building stash todo: fix start service hang try to reuse codegen proxy finish admin service impl add lock guard for write refactor format reorg http_server new_interface expose admin_endpoint modify gs_interactive fix yaml test fix CI fix gs_interactive_pegasus close_lib add doc and test use engine_config_test.yaml rather than gs_test fix ci fix CI fix path to engine_config_test.yaml update update doc minor fix test rename StoredProcedureManager to StoredProcedureProxy fix CI TODO: fix CI
50d45f4
to
30955c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engines/http_server
directory. Put allactors
in actor directory, allhandlers
in handler direcotry, allservices
in service directory.nlohmann/json
, since we need to parse the http request body as json string, and also return the results in json format.interactive_server
, which start the both the admin service and the query service.service_utils.h
.LoadFromDataDirectory
method forGraphDB
, support deserialized graph from data directory withoutbulk_load
andschema
given. GraphDB can also switch between graphs via this method.GraphManager
to provide graph management and procedure management. Coarse-grained lock will be utilized for stage-changing operations.