Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Introduce MetricsTool to profile memory usage, pending tasks and qps #4332

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Nov 21, 2024

What do these changes do?

the MetricsTool will print the following metrics periodically (setting of metrics.tool.interval.ms, default is 5 mins):

  1. memory.usage: memory usage of jvm and direct memory
  2. rpc.channels.executor.queue: pending tasks in each grpc (netty) channel
  3. gremlin.executor.queue: pending tasks in gremlin executor
  4. gremlin.qps: gremlin qps

These metrics will be logged in a separate file, configured by PerfMetricLog in logback.xml

Related issue number

Fixes

@shirly121 shirly121 changed the title fix(interactive): Introduce MetricsTool to profile memory usage and pending tasks fix(interactive): Introduce MetricsTool to profile memory usage, pending tasks and qps Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Please check the preview of the documentation changes at
https://a36e6e50.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@cd7879c). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4332   +/-   ##
=======================================
  Coverage        ?   34.32%           
=======================================
  Files           ?      126           
  Lines           ?    13252           
  Branches        ?        0           
=======================================
  Hits            ?     4549           
  Misses          ?     8703           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7879c...79f4ccc. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants